[Metricbeat] Add README to mocked tests folder#11714
Merged
sayden merged 4 commits intoelastic:masterfrom Apr 24, 2019
Merged
Conversation
sayden
added
review
Metricbeat
sayden
force-pushed
the
feature/mb/add-readme-to-mocked-tests
branch
from
6e778b3 to
728f42c
Compare
Contributor
Author
|
@ruflin can you take a look here? please :) |
| #### What it is | ||
| Many modules do requests to an HTTP endpoint to fetch metrics data. Then they do data manipulation and enriching of this data before sending it to Elasticsearch. | ||
|
|
||
| What we wanted to achieve is to mock the HTTP responses from the modules into a generic server that will serve those responses. So, for each tested metricset, an HTTP server is launched at a random port (but be aware that JSON responses written to disk are hardcoded with value "127.0.0.1:5555") with the mocked response from a fixed module version to respond to the HTTP requests, once the test is done, it's shut down.. This way we isolate the manipulation of data in some tests and reduce lot of boilerplate we had in many modules. |
ruflin
approved these changes
Apr 24, 2019
Contributor
ruflin
left a comment
ruflin
left a comment
There was a problem hiding this comment.
LGTM (except the 2 dots 🤣 )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split PR from here #11703
Added a README.md file to the folder where the code is located showing current options, flags and use.